[Build] Add flag to build-win.ps1 that allows to build Release.static target#1408
Open
lucianopa-msft wants to merge 4 commits intomicrosoft:mainfrom
Open
[Build] Add flag to build-win.ps1 that allows to build Release.static target#1408lucianopa-msft wants to merge 4 commits intomicrosoft:mainfrom
lucianopa-msft wants to merge 4 commits intomicrosoft:mainfrom
Conversation
d170ce2 to
0c41a33
Compare
ThomsonTan
reviewed
Jan 28, 2026
Co-authored-by: Tom Tan <lilotom@gmail.com>
Member
Author
|
cc @ThomsonTan |
ThomsonTan
reviewed
Feb 4, 2026
| if ($libMTSqlite -eq "true") { | ||
| $actualConfig += ".vc14x.MT-sqlite" | ||
| } else { | ||
| $actualConfig += ".static" |
Contributor
There was a problem hiding this comment.
Because static libs are only supported for x86/x64, should a check be added here to do the guard?
Member
Author
There was a problem hiding this comment.
There is already a check bellow on line 83
if ($binType -eq "lib" -and ($actualArch -eq "ARM")) {that will skip building static lib anyways for arm.
It could be done earlier, but checking here would be redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are building using this build-win.ps1 but we wanted to be able to use the "Release.static" target. But currently there is no such option to that.
We currently have our own workaround:
Which is fine, but sending this PR aiming to allow that option as well. Default remains
trueto not modify current behavior.